allow to query photos and videos also from external storages in gallery

[szaimen]

Attempt to fix nextcloud/android#8618

Inspired by nextcloud/photos#804

Best reviewed like this: https://github.com/nextcloud/android-library/pull/782/files?diff=unified&w=1

Signed-off-by: szaimen szaimen@e.mail.de

[szaimen]

/backport to stable-2.8

[szaimen]

@tobiasKaminsky @AlvaroBrey I have no idea what I am doing so please review carefully :)
(I also didn't test this)

[codecov]

Codecov Report

Merging #782 (844c518) into master (21223dd) will increase coverage by 0.20%.
The diff coverage is n/a.

❗ Current head 844c518 differs from pull request most recent head b3eb97c. Consider uploading reports for the commit b3eb97c to get more accurate results

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   46.07%   46.28%   +0.20%     
==========================================
  Files         164      164              
  Lines        6352     6343       -9     
  Branches      832      832              
==========================================
+ Hits         2927     2936       +9     
+ Misses       2988     2970      -18     
  Partials      437      437              

Impacted Files	Coverage Δ
...ud/android/lib/resources/files/NcSearchMethod.java	97.25% <ø> (-0.13%)	⬇️
...wncloud/android/lib/resources/files/FileUtils.java	85.71% <0.00%> (+14.28%)	⬆️
...xtcloud/android/lib/resources/profile/HoverCard.kt	20.00% <0.00%> (+20.00%)	⬆️
...b/resources/profile/GetHoverCardRemoteOperation.kt	65.21% <0.00%> (+65.21%)	⬆️

[AlvaroBrey]

Getting closer now :)

To fix compilation issues:

• Import GetCapabilitiesRemoteOperation and OCCapability in SearchRemoteOperation
• Add the @JvmField annotation to NextcloudVersion.nexctloud_22, as it is for nextcloud_22, otherwise it's private.

Additionally, I think it would be better to pass either the entire OCCapability object, or the version, to NcSearchMethod, and then check the version inside that (rather than checking the version in SearchOperation). This way is more flexible and SearchOperation is kept a bit more decoupled from the inner workings of NcSearchMethod.

[tobiasKaminsky]

Calling get remote capability all the time is a bit overhead, I think.
Just add the capability to SearchRemoteOperation, so that it is required.

I think I added this to an already resolved communication.

[szaimen]

I hope I addressed all points. Though the compilation still fails :/
Please have another look! :)

[nextcloud-android-bot]

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	38
Internationalization Warnings	6
Malicious code vulnerability Warnings	54
Multithreaded correctness Warnings	3
Performance Warnings	14
Security Warnings	1
Dodgy code Warnings	44
Total	174

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	38
Internationalization Warnings	6
Malicious code vulnerability Warnings	52
Multithreaded correctness Warnings	3
Performance Warnings	14
Security Warnings	1
Dodgy code Warnings	44
Total	172

[AlvaroBrey]

Looks good, however this now needs changes in the app, in order to pass the new OCCapability param to SearchRemoteOperation wherever needed.

[tobiasKaminsky]

Client PR in nextcloud/android#9651