Fix scrolling detection on activity 14#293
Merged
nickvergessen merged 2 commits intomasterfrom Sep 10, 2018
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
js/script.js
Outdated
| prefill: function () { | ||
| this.ignoreScroll += 1; | ||
| if (this.$content.scrollTop() + this.$content.height() > this.$container.height() - 100) { | ||
| if (this.$content.scrollTop() + $(window).height() > this.$container.height() + 100) { |
Member
There was a problem hiding this comment.
I will make it -100 again, so new activities are already loaded, before you reach the end, so ideally you never see the loading circle
Member
Author
There was a problem hiding this comment.
Ah, make sense now. I couldn't figure why it was set to -100!
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
approved these changes
Sep 10, 2018
Member
|
Can you prepare a backport on stable14? |
Member
Author
|
Of course! :) |
Member
Member
|
Ah it was already backported in #295 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #292