chore(exception)!: Enhance exception handling#760
Conversation
de7ff25 to
d37ae77
Compare
|
... rebased with latest toolchain in place... |
- Replace http://localhost/ with http://example.com[/] because localhost ist a possible valid host and therefore confusing for users. Considered info-removed-for-privacy-reasons.com (or something similar), but there is no guarantee that this domain is not registered. example.com can by definition not be registered. - Unify way to create a response on an exception by passing the whole exception object into the helper method - Use HTTP 900 for unknown exceptions to distinguish other proprietary status codes: HTTP 520 is for example used by Cloudflare. Note that HTTP 900 is also not standardized. Signed-off-by: Stefan Niedermann <info@niedermann.it>
d37ae77 to
f6faee8
Compare
AndyScherzinger
left a comment
There was a problem hiding this comment.
LGTM, codacy can be ignored 👍
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Uh oh!
There was an error while loading. Please reload this page.