Skip to content

fix(deps): update dependency com.squareup.okhttp3:okhttp to v4#645

Merged
AndyScherzinger merged 2 commits intomainfrom
renovate/major-okhttp-monorepo
Jan 31, 2024
Merged

fix(deps): update dependency com.squareup.okhttp3:okhttp to v4#645
AndyScherzinger merged 2 commits intomainfrom
renovate/major-okhttp-monorepo

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jan 24, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.squareup.okhttp3:okhttp (source) 3.14.9 -> 4.12.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Jan 24, 2024
@renovate renovate bot changed the title fix(deps): update dependency com.squareup.okhttp3:okhttp to v4 Update dependency com.squareup.okhttp3:okhttp to v4 Jan 24, 2024
@renovate renovate bot changed the title Update dependency com.squareup.okhttp3:okhttp to v4 fix(deps): update dependency com.squareup.okhttp3:okhttp to v4 Jan 24, 2024
@renovate renovate bot force-pushed the renovate/major-okhttp-monorepo branch 2 times, most recently from e674bd3 to f7e1f82 Compare January 30, 2024 08:22
@AndyScherzinger
Copy link
Member

@stefan-niedermann @David-Development merge-able from your perspective ?

@AndyScherzinger AndyScherzinger added this to the SSO Library 1.1.0 milestone Jan 30, 2024
@renovate renovate bot force-pushed the renovate/major-okhttp-monorepo branch from f7e1f82 to 9e3afa6 Compare January 30, 2024 09:48
@renovate renovate bot force-pushed the renovate/major-okhttp-monorepo branch from 9e3afa6 to 062c964 Compare January 30, 2024 09:54
@stefan-niedermann
Copy link
Member

Honestly: No idea. Does anyone know a 3rd party app actually using the OkHttp backend?

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Copy link
Member

Don't know, at least Nextcloud News uses okhttp in its dependencies, see https://github.com/nextcloud/news-android/blob/master/News-Android-App/build.gradle#L122 ff

@AndyScherzinger
Copy link
Member

But then it defined 4.12, so I think it be fine to bump it to the same version here

@renovate
Copy link
Contributor Author

renovate bot commented Jan 30, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link
Member

@David-Development David-Development left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this branch in the news app and it seems to be working perfectly fine. So no blockers from my end 👍

@AndyScherzinger AndyScherzinger merged commit 35a8537 into main Jan 31, 2024
@AndyScherzinger AndyScherzinger deleted the renovate/major-okhttp-monorepo branch January 31, 2024 22:11
@AndyScherzinger
Copy link
Member

Thanks @David-Development for testing and feedback 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants