Conversation
This cleans up the dependencies a bit an reduces the bootstrap process. As we require PHP 8.1+ we do not need polyfills for 8.1 and lower. Moreover `ctype` and `mbstring` are required as per our system requirements. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The polyfills for 8.3 already were added as implicit dependencies, but now marked as explicit dependency. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
We do not use the grapheme extension, it was added together with IDN polyfills, but we only use the IDN ones. So we do not need an explicit dependency here. It will still be included for the moment, as we have some dependencies that require it, so it is now an implicit dependency. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 task
kesselb
reviewed
Aug 12, 2025
kesselb
approved these changes
Aug 12, 2025
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the polyfills for newer PHP versions - above our min version - to the dependencies.
Allowing us to write modern code without copy-paste the implementation of the new API (e.g.
array_any).Once that version is our new minimum we can just remove the polyfill and do not need to refactor our code base.
The polyfills for 8.3 already were added as implicit dependencies, but now marked as explicit dependency.
Additionally cleaned up the existing polyfills: