Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Contributor
Author
|
Not sure what you put as svg file. Is it mandatory? |
Member
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Contributor
Author
|
done |
nickvergessen
approved these changes
Apr 4, 2022
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
|
For demo see here nextcloud/privacy#755 |
Member
|
you could also have one config with a matrix of the four databases |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Contributor
Author
|
@nickvergessen @ChristophWurst Testing in nextcloud/activity#777 as an example, the tests fail, do you think it comes from the removed |
Member
|
Seems to be unrelated as moving it up and enabling it doesn't seem to fix it. |
Member
Seems much cleaner to have 4 smaller yml files. 🤷 |
skjnldsv
approved these changes
Apr 5, 2022
Member
|
Looks great!! 🚀 |
Contributor
Author
But it does not work yet on nextcloud/activity#777 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported from app-tutorial.
Modified to detect APP_NAME from repository name.
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com