fix(NcActions): intercept into current focus trap stack#4953
Merged
Conversation
9463ffc to
234bec9
Compare
234bec9 to
7f8fa2d
Compare
Contributor
Author
|
Could be risky. A good review is appreciated 👀 |
Contributor
|
Doesn't work on Photos well ;( -> seems to be a regression, works on try.extcloud
|
Contributor
Author
I cannot reproduce. The On what page what it is recorded? |
Contributor
Author
|
The issue happens when there are any inline actions. They are also counted in menu actions when determining what kind of menu we have. Preparing another PR. |
2 tasks
7f8fa2d to
3297d51
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
3297d51 to
6060690
Compare
JuliaKirschenheuter
approved these changes
Jan 29, 2024
Contributor
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
works, great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcActionsdoesn't work inside an element with a focus trap in a general case #4910When the component has its own focus trap, then it is managed by global trap stack by focus-trap.
However if the component has no focus trap and is used inside another focus trap - there is an issue. By default popover content is rendered in body or other container, which is likely outside the current focus trap containers. It results in broken behavior from focus-trap.
We need to pause all the focus traps for opening popover and then unpause them back after closing.
🖼️ Screenshots
Focus trap still works.
Supports multi-level focus traps (header menu focus trap inside sidebar trap):
🏁 Checklist