Skip to content

DI config: add spread operator#158

Open
matej21 wants to merge 1 commit intonette:masterfrom
matej21:feature/spread-operator
Open

DI config: add spread operator#158
matej21 wants to merge 1 commit intonette:masterfrom
matej21:feature/spread-operator

Conversation

@matej21
Copy link
Contributor

@matej21 matej21 commented Aug 14, 2017

  • bug fix? no
  • new feature? yes
  • BC break? yes (when someone concats ... with a scalar parameter. it could be fixed by checking whether return value is an array, but is it worth it?)

@matej21 matej21 force-pushed the feature/spread-operator branch from f9ed939 to 0891cbd Compare August 14, 2017 14:02
@matej21 matej21 force-pushed the feature/spread-operator branch from 0891cbd to e10cee9 Compare August 14, 2017 14:40
@dg
Copy link
Member

dg commented Aug 19, 2017

For accuracy: it is not like PHP spread operator, because it works with keys, so DbConnection(...%connection%) in NEON and new DbConnection(...$connection) in PHP may work different.

@dg dg force-pushed the master branch 5 times, most recently from 4243866 to e8187b3 Compare August 31, 2017 22:43
@f3l1x
Copy link
Member

f3l1x commented Feb 18, 2018

It would be fine merge it or reject it. What do you think? I could be the fine feature in Nette 3?

@dg dg force-pushed the master branch 2 times, most recently from e78d4c1 to b36d041 Compare March 28, 2018 23:57
@dg dg force-pushed the master branch 2 times, most recently from ec720a7 to 9d3541e Compare June 11, 2018 08:45
@dg dg force-pushed the master branch 3 times, most recently from 8224b32 to d51ca9e Compare September 16, 2018 21:16
@dg dg force-pushed the master branch 3 times, most recently from 1fc7645 to 485a875 Compare October 3, 2018 16:24
@dg dg added this to the v3.0 milestone Oct 3, 2018
@dg dg force-pushed the master branch 4 times, most recently from a27a10b to 594a33a Compare October 5, 2018 18:18
@dg dg force-pushed the master branch 10 times, most recently from 286f0d8 to e7fa17c Compare October 17, 2018 01:02
@dg dg force-pushed the master branch 20 times, most recently from 3efdd43 to 197ae89 Compare October 25, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants