Missing accessibilityRole="option"#1682
Closed
jonstuebe wants to merge 1 commit into
Closed
Conversation
Owner
|
|
Author
|
Is there a fall through in the code somewhere @necolas? I'm using TS so it sounds like a type issue then. |
Owner
|
Ah, yes it might be typescript. There was another types issue that was brought up recently #1668. As time goes I'm starting to wonder more about types. Maybe I'll make another issue to solicit input about types. |
Owner
|
If you have any thoughts: #1684 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been building a combobox and found that
react-native-webis missing theaccessibilityRole="option"necessary for proper voice over. I might be missing some other changes below as I'm not super familiar with the codebase.Here's a link to the spec examples detailing the role usage:
https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html