This repository was archived by the owner on Aug 24, 2023. It is now read-only.
Sourcery Starbot ⭐ refactored nbrosse/controlvariates#1
Open
SourceryAI wants to merge 1 commit intonbrosse:masterfrom
Open
Sourcery Starbot ⭐ refactored nbrosse/controlvariates#1SourceryAI wants to merge 1 commit intonbrosse:masterfrom
SourceryAI wants to merge 1 commit intonbrosse:masterfrom
Conversation
SourceryAI
commented
Mar 23, 2022
|
|
||
| #from scipy.optimize import minimize | ||
|
|
Author
There was a problem hiding this comment.
Lines 17-38 refactored with the following changes:
- Replace identity comprehension with call to collection constructor (
identity-comprehension)
| area = (xv[0, 1] - xv[0, 0])*(yv[1, 0] - yv[0, 0]) | ||
| var = 2*np.sum(var)*area | ||
| print('var: {}'.format(var)) | ||
| print(f'var: {var}') |
Author
There was a problem hiding this comment.
Lines 115-115 refactored with the following changes:
- Replace call to format with f-string. (
use-fstring-for-formatting)
| df3[compt] = tab_titles[k] | ||
| compt +=1 | ||
|
|
Author
There was a problem hiding this comment.
Lines 70-291 refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Hoist statements out of for/while loops (
hoist-statement-from-loop)
|
|
||
| #from scipy.optimize import minimize | ||
|
|
Author
There was a problem hiding this comment.
Lines 17-66 refactored with the following changes:
- Replace identity comprehension with call to collection constructor (
identity-comprehension)
| plt.show() | ||
| #fig.savefig("approx_pi_Lpois_2d_nabla_rcond5.jpeg", bbox_inches='tight') | ||
|
|
Author
There was a problem hiding this comment.
Lines 139-153 refactored with the following changes:
- Replace call to format with f-string. (
use-fstring-for-formatting)
|
|
||
| #from scipy.optimize import minimize | ||
|
|
Author
There was a problem hiding this comment.
Lines 17-38 refactored with the following changes:
- Replace identity comprehension with call to collection constructor (
identity-comprehension)
Comment on lines
-118
to
+124
|
|
||
| # coeffs_pois = np.linalg.lstsq(L_pois, - f_tilde_flatten, rcond=rcond)[0] | ||
| # | ||
| # dxpois = np.dot(dxpois_mesh, coeffs_pois[:nb_bases**2]) | ||
| # dypois = np.dot(dypois_mesh, coeffs_pois[nb_bases**2:]) | ||
| # Lpois = np.dot(Lx_pois, coeffs_pois[:nb_bases**2]) + np.dot(Ly_pois, coeffs_pois[nb_bases**2:]) | ||
|
|
Author
There was a problem hiding this comment.
Lines 118-162 refactored with the following changes:
- Replace call to format with f-string. (
use-fstring-for-formatting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: