Skip to content

Reader Listener #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scottf merged 7 commits into from
Jan 9, 2025
Merged

Reader Listener #1265

scottf merged 7 commits into from
Jan 9, 2025

Conversation

@scottf
Copy link
Contributor

@scottf scottf commented Jan 6, 2025

A way to debug incoming messages before they are processed

@scottf
Reader Listener
5a4ebfe 
A way to debug incoming messages before they are processed
@scottf scottf requested a review from MauriceVanVeen January 6, 2025 23:02
scottf added 2 commits January 6, 2025 19:01
@scottf
Reader Listener
4d23323 
A way to debug incoming messages before they are processed
@scottf
Reader Listener
2cd23c0 
A way to debug incoming messages before they are processed
MauriceVanVeen
MauriceVanVeen approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/java/io/nats/client/ReadListener.java Outdated
@@ -0,0 +1,19 @@
// Copyright 2015-2018 The NATS Authors
Copy link
Member

@MauriceVanVeen MauriceVanVeen Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the copyright date be updated?

@scottf
Copy link
Contributor Author

scottf commented Jan 9, 2025 •
edited
Loading

Basic benchmark comparison shows no loss in speed, safe to merge.

┌─────────────────────┬───────────────────┬─────────────────┬──────────────────────────┬──────────────────┐
│ 2.20.5              │             count │            time │                 msgs/sec │        bytes/sec │
├─────────────────────┼───────────────────┼─────────────────┼──────────────────────────┼──────────────────┤
│ PubAsync            │   50,000,000 msgs │       28:37.522 │      29,111.709 msgs/sec │      6.94 mb/sec │
├─────────────────────┼───────────────────┼─────────────────┼──────────────────────────┼──────────────────┤
│ SubFetch            │   50,000,000 msgs │       35:23.774 │      23,542.995 msgs/sec │      5.61 mb/sec │
├─────────────────────┼───────────────────┼─────────────────┼──────────────────────────┼──────────────────┤
│ SubIterate          │   50,000,000 msgs │       17:10.329 │      48,528.189 msgs/sec │     11.57 mb/sec │
└─────────────────────┴───────────────────┴─────────────────┴──────────────────────────┴──────────────────┘

┌─────────────────────┬───────────────────┬─────────────────┬──────────────────────────┬──────────────────┐
│ 2.20.6-SNAPSHOT     │             count │            time │                 msgs/sec │        bytes/sec │
├─────────────────────┼───────────────────┼─────────────────┼──────────────────────────┼──────────────────┤
│ PubAsync            │   50,000,000 msgs │       27:10.364 │      30,667.998 msgs/sec │      7.31 mb/sec │
├─────────────────────┼───────────────────┼─────────────────┼──────────────────────────┼──────────────────┤
│ SubFetch            │   50,000,000 msgs │       34:27.336 │      24,185.715 msgs/sec │      5.77 mb/sec │
├─────────────────────┼───────────────────┼─────────────────┼──────────────────────────┼──────────────────┤
│ SubIterate          │   50,000,000 msgs │       16:36.262 │      50,187.601 msgs/sec │     11.97 mb/sec │
└─────────────────────┴───────────────────┴─────────────────┴──────────────────────────┴──────────────────┘

┌─────────────────────┬───────────────────┬─────────────────┬──────────────────────────┬──────────────────┐
│ .6.reader-listener  │             count │            time │                 msgs/sec │        bytes/sec │
├─────────────────────┼───────────────────┼─────────────────┼──────────────────────────┼──────────────────┤
│ PubAsync            │   50,000,000 msgs │       28:20.610 │      29,401.215 msgs/sec │      7.01 mb/sec │
├─────────────────────┼───────────────────┼─────────────────┼──────────────────────────┼──────────────────┤
│ SubFetch            │   50,000,000 msgs │       35:14.739 │      23,643.580 msgs/sec │      5.64 mb/sec │
├─────────────────────┼───────────────────┼─────────────────┼──────────────────────────┼──────────────────┤
│ SubIterate          │   50,000,000 msgs │       17:22.491 │      47,962.045 msgs/sec │     11.44 mb/sec │
└─────────────────────┴───────────────────┴─────────────────┴──────────────────────────┴──────────────────┘

@scottf scottf merged commit 366ae9f into main Jan 9, 2025
4 checks passed
@scottf scottf deleted the reader-listener branch January 9, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauriceVanVeen MauriceVanVeen MauriceVanVeen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottf @MauriceVanVeen