-
Notifications
You must be signed in to change notification settings - Fork 182
Javadocs Improvements #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javadocs Improvements #1221
Conversation
scottf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor spelling. Please remove all functional changes to a different PR so we can move ahead with the doc changes.
src/main/java/io/nats/client/impl/NatsOrderedConsumerContext.java
Outdated
Show resolved
Hide resolved
This reverts commit 1c65472.
|
OK, split the functional changes. Cleaned up trailing white space. |
scottf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Misc documentation changes regarding new style API-
Fail fast on createConsumerContext when a push consumer is provided