Skip to content

Conversation

@roeschter
Copy link
Collaborator

@roeschter roeschter commented Sep 3, 2024

Misc documentation changes regarding new style API-
Fail fast on createConsumerContext when a push consumer is provided

  • Added a proper test for failure - But tested so far with my own test code only

Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling. Please remove all functional changes to a different PR so we can move ahead with the doc changes.

@roeschter
Copy link
Collaborator Author

OK, split the functional changes. Cleaned up trailing white space.

Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 346cc29 into main Sep 9, 2024
@scottf scottf deleted the Javadocs03 branch September 9, 2024 13:33
@scottf scottf changed the title Javadocs03 Javadocs Improvements Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants