Remove redundant writer.flushBuffer() call
#1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a request through `requestFutureInternal` we'd publish the message into the outgoing write queue, and immediately after call `writer.flushBuffer()`. Due to the message needing to go through the outgoing message queue, which takes a small amount of time, the `flushBuffer` would be done first and before our message got written to the `dataPort`. Removing the call to `writer.flushBuffer()` since it doesn't actually flush our message/request. Signed-off-by: Maurice van Veen <[email protected]>
scottf
approved these changes
Aug 19, 2024
Contributor
scottf
left a comment
There was a problem hiding this comment.
Agreed, doesn't make much sense since the flush will occur before the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a request through
requestFutureInternalwe'd publish the message into the outgoing write queue, and immediately after callwriter.flushBuffer().Due to the message needing to go through the outgoing message queue, which takes a small amount of time, the
flushBufferwould be done first and before our message got written to thedataPort.Removing the call to
writer.flushBuffer()since it doesn't actually flush our message/request.Signed-off-by: Maurice van Veen [email protected]