CONNECT username and password need json encoding #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
commented
Jun 26, 2024
| } | ||
|
|
||
| @Test | ||
| @EnabledOnOs({ WINDOWS }) |
Contributor
Author
There was a problem hiding this comment.
I could not get this run on GH Actions. I'm assuming that it has something to do with how the command line handles control characters on unix systems.
scottf
commented
Jun 26, 2024
| } | ||
| break; | ||
| } | ||
| appendChar(sb, s.charAt(x)); |
Contributor
Author
There was a problem hiding this comment.
refactored for reuse when the entry is string or char array
scottf
commented
Jun 26, 2024
| private static void appendOption(CharBuffer builder, String key, char[] value, boolean quotes, boolean comma) { | ||
| _appendStart(builder, key, quotes, comma); | ||
| @SuppressWarnings("SameParameterValue") | ||
| private static void appendOption(CharBuffer builder, String key, char[] value, boolean comma) { |
Contributor
Author
There was a problem hiding this comment.
When used for a char array, it always represents a string value, so must be in quotes
scottf
commented
Jun 26, 2024
|
|
||
| if (uriUser != null) { | ||
| appendOption(connectString, Options.OPTION_USER, uriUser, true, true); | ||
| appendOption(connectString, Options.OPTION_USER, jsonEncode(uriUser), true, true); |
Contributor
Author
There was a problem hiding this comment.
json encode since this is json, and it's a string that is provided by the user. I said this to say that I didn't encode some strings in this function since I know that they are already json safe, like the jwt which is base64 encoded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.