Skip to content

CMR-11300: Add missing uuid lookups for the keyword schemes: providers and spatial-keywords#2428

Open
eudoroolivares2016 wants to merge 1 commit into
masterfrom
CMR-11300
Open

CMR-11300: Add missing uuid lookups for the keyword schemes: providers and spatial-keywords#2428
eudoroolivares2016 wants to merge 1 commit into
masterfrom
CMR-11300

Conversation

@eudoroolivares2016
Copy link
Copy Markdown
Contributor

@eudoroolivares2016 eudoroolivares2016 commented May 13, 2026

Overview

What is the objective?

Adds the lookup for providers scheme. Fixes spatial keyword lookup to use the new cache though the results would be unchanged

What are the changes?

Update kms_util index which looks over collection metadata and does a lookup against the keyword scheme corresponding to that scheme (providers and sptial-keywords)

What areas of the application does this impact?

Collection indxing

Required Checklist

  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors in changed files are corrected
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation (if necessary)
  • My changes generate no new warnings

Additional Checklist

  • [NA] I have removed unnecessary/dead code and imports in files I have changed

  • [NA] I have cleaned up integration tests by doing one or more of the following:

    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • reduced number of system state resets by updating fixtures. Ex) (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

    Green build:
    https://ci.earthdata.nasa.gov/browse/CN2-CSN2970-3

@eudoroolivares2016 eudoroolivares2016 changed the title CMR-11300: Fix missing uuid lookups for the concept scheme providers … CMR-11300: Add missing uuid lookups for the keyword schemes: providers and spatial-keywords May 13, 2026
@eudoroolivares2016 eudoroolivares2016 marked this pull request as ready for review May 19, 2026 20:11
@eudoroolivares2016 eudoroolivares2016 force-pushed the CMR-11300 branch 2 times, most recently from 769a826 to 3e90f31 Compare May 27, 2026 00:04
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 27, 2026

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.12%. Comparing base (2231052) to head (0e771d1).

Files with missing lines Patch % Lines
...r-app/src/cmr/indexer/data/concepts/collection.clj 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2428      +/-   ##
==========================================
- Coverage   58.13%   58.12%   -0.02%     
==========================================
  Files        1069     1069              
  Lines       73870    73879       +9     
  Branches     2157     2153       -4     
==========================================
- Hits        42947    42944       -3     
- Misses      28915    28924       +9     
- Partials     2008     2011       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…and fix using the new cache lookup for spatial-keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants