Fixed android release build crash#21
Merged
naoufal merged 3 commits intonaoufal:masterfrom Oct 10, 2016
Merged
Conversation
…ting it (package warning was missing). It now provides the same interface as on iOS for feature detection.
|
Awesome work @Richardvanwill !!! @naoufal - I'd love to see this release. |
|
👍 |
Owner
|
thanks for the PR will get it merged and published later today |
|
Hi @naoufal . Are there any updates on publishing this PR? Thanks! |
Owner
|
@pkwak-sf, @kiruys, @GantMan, @Richardvanwill published to npm under |
pkwak-sf
added a commit
to pkwak-sf/react-native-passcode-auth
that referenced
this pull request
Oct 10, 2016
Identical fix from naoufal/react-native-touch-id#21
pkwak-sf
added a commit
to pkwak-sf/react-native-passcode-auth
that referenced
this pull request
Oct 10, 2016
Identical fix from naoufal/react-native-touch-id#21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19
This fixes the import of the package on android. It did not import TouchID.android.js when used as a node module.
It also fixes the android js: it now provides the same interface for feature detection as the ios version, just returning false on isSupported(), instead of throwing an error on an undefined package "warning".