refactor ens-deployments package (now datasources) & usage #792

shrugs · 2025-06-18T18:58:52Z

closes #790

renamed package from @ensnode/ens-deployments to @ensnode/datasources
removed top-level export in favor of util getDatasourceMap and getDatasource
added ENSNamespace type and value using POJO to make public API easier to use
refactored DatasourceName into POJO enum as well
'ENS deployment' -> 'ENS namespace'
all 'deployment' references are now exclusively referring to the concept of a devops deployment of ENSNode
original plugin namespace concept renamed to pluginNamespace
Deployment -> DatasourceMap

…le to L1_CHAIN

changeset-bot · 2025-06-18T18:58:56Z

🦋 Changeset detected

Latest commit: dd0de1c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-06-18T18:58:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
admin.ensnode.io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 23, 2025 11:17am
ensnode.io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 23, 2025 11:17am
ensrainbow.io	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 23, 2025 11:17am

apps/ensindexer/src/config/validations.ts

apps/ensindexer/src/handlers/Registry.ts

apps/ensindexer/src/lib/ponder-helpers.ts

apps/ensindexer/src/plugins/basenames/handlers/Registrar.ts

lightwalker-eth

@shrugs Hey nice updates 👍 Reviewed and shared suggestions. Please merge when ready 🙌

apps/ensadmin/.env.local.example

apps/ensadmin/src/components/ensnode/hooks.ts

apps/ensindexer/.env.local.example

apps/ensindexer/src/config/types.ts

apps/ensindexer/src/handlers/Registry.ts

apps/ensadmin/src/lib/chains.ts

…rces

shrugs · 2025-06-20T16:08:18Z

once again suggesting the replacement of L1Chain and associated words with ENS namespace and ENSNamespace. the language around using L1Chain is verbose and confusing, and it seems extremely clear to me that what we're discriminating between, at the top-level, is isolated ENS namespaces, not "L1s that host the root registry". as you said yourself there could be another deployment of ENS to mainnet, and ENSNode could technically support it — it's not the L1 that is the unique discriminator, it's the ENS namespace itself (and its associated contract addresses etc) that we're switching between. the ensroot Datasource defines which chain hosts the ENS Root contracts.

i.e. just replacing the word "deployment" with "namespace", no other logical changes.

i don't know, this seems extremely clear to me, but perhaps i'm missing something?

lightwalker-eth

@shrugs Hey super updates here 😄 Reviewed and shared a few ideas 👍

apps/ensindexer/src/lib/ponder-helpers.ts

apps/ensindexer/src/plugins/basenames/plugin.ts

apps/ensindexer/test/dns-helpers.test.ts

packages/datasources/src/lib/types.ts

packages/datasources/src/index.ts

packages/datasources/README.md

apps/ensindexer/src/config/derived-params.ts

shrugs · 2025-06-21T15:01:02Z

i'm in favor of not using the datasource/instance terminology, i don't see the specific need for it

lightwalker-eth

@shrugs Very happy. Awesome updates that help to simplify the mental model a lot!

apps/ensindexer/src/config/types.ts

packages/datasources/src/index.ts

packages/datasources/README.md

apps/ensindexer/src/lib/plugin-helpers.ts

lightwalker-eth

A few other little ideas 👍 @shrugs Please decide as you wish.

README.md

apps/ensadmin/.env.local.example

apps/ensindexer/src/lib/plugin-helpers.ts

shrugs · 2025-06-23T11:15:42Z

i've gone with the verbose but explicit DatasourceMapFullyDefinedAtCompileTime and associated function names to clearly communicate its behavior

shrugs · 2025-06-23T11:19:20Z

and i've refactored the global config usage out of the ponder-helper and plugin-helpers for better separation of concerns

shrugs added 3 commits June 18, 2025 19:29

checkpoint: initial rename

9960595

checkpoint: additional renaming and editing

a658291

docs(changeset): rename the ENS_DEPLOYMENT_CHAIN configuration variab…

6a993eb

…le to L1_CHAIN

shrugs requested a review from a team as a code owner June 18, 2025 18:58

vercel bot had a problem deploying to Preview – ensnode.io June 18, 2025 18:59 Failure

vercel bot deployed to Preview – ensrainbow.io June 18, 2025 18:59 View deployment

vercel bot deployed to Preview – admin.ensnode.io June 18, 2025 19:00 View deployment

shrugs commented Jun 18, 2025

View reviewed changes

lightwalker-eth approved these changes Jun 19, 2025

View reviewed changes

shrugs added 3 commits June 20, 2025 15:53

chore: rename ens-deployments to datasources

9dd36af

fix: correct changeset config

7d53491

docs(changeset): renamed @ensnode/ens-deployments to @ensnode/datasou…

35c2568

…rces

vercel bot deployed to Preview – admin.ensnode.io June 20, 2025 14:55 View deployment

vercel bot deployed to Preview – ensrainbow.io June 20, 2025 14:56 View deployment

vercel bot had a problem deploying to Preview – ensnode.io June 20, 2025 14:56 Failure

shrugs added 4 commits June 20, 2025 16:48

checkpoint: refactor variables and import from ensnode/datasources

a6ca10b

fix: refactor config.ensDeployment into config.datasources

0607b54

fix: DatasourceName.Root to DatasourceName.ENSRoot

763b0ba

fix: datasource name ref

6a2c074

vercel bot deployed to Preview – admin.ensnode.io June 20, 2025 15:53 View deployment

vercel bot deployed to Preview – ensnode.io June 20, 2025 15:54 View deployment

vercel bot deployed to Preview – ensrainbow.io June 20, 2025 15:54 View deployment

lightwalker-eth reviewed Jun 20, 2025

View reviewed changes

shrugs changed the title ~~rename ENS_DEPLOYMENT_CHAIN (+etc) to L1_CHAIN (+etc)~~ refactor ens-deployments package (now datasources) & usage Jun 20, 2025

checkpoint: l1 chain to ens namespace

1db2cce

vercel bot deployed to Preview – ensrainbow.io June 21, 2025 11:40 View deployment

vercel bot deployed to Preview – ensnode.io June 21, 2025 11:40 View deployment

vercel bot deployed to Preview – admin.ensnode.io June 21, 2025 11:42 View deployment

shrugs added 7 commits June 21, 2025 15:00

fix: terraform variables

147033d

fix: refactor getENSRootChainId

afdde1b

checkpoint: refactor getDatasource api

3490ad6

checkpoint: refactor DatasourceName into POJO enum

3c7ae69

refactor: remove the ENS prefix from namespace where applicable

6a679db

fix: move common datasource accessors to plugin-helpers

589d891

fix: readme

9299ceb

fix: namespace to pluginNamespace, ns

153d524

vercel bot deployed to Preview – admin.ensnode.io June 21, 2025 15:11 View deployment

vercel bot deployed to Preview – ensnode.io June 21, 2025 15:12 View deployment

vercel bot deployed to Preview – ensrainbow.io June 21, 2025 15:12 View deployment

fix: Datasources-> DatasourceMap

dd0de1c

vercel bot deployed to Preview – ensnode.io June 21, 2025 15:19 View deployment

vercel bot deployed to Preview – admin.ensnode.io June 21, 2025 15:20 View deployment

vercel bot deployed to Preview – ensrainbow.io June 21, 2025 15:21 View deployment

lightwalker-eth approved these changes Jun 22, 2025

View reviewed changes

apps/ensindexer/src/config/types.ts Outdated Show resolved Hide resolved

packages/datasources/src/index.ts Outdated Show resolved Hide resolved

packages/datasources/README.md Outdated Show resolved Hide resolved

apps/ensindexer/src/lib/plugin-helpers.ts Outdated Show resolved Hide resolved

lightwalker-eth reviewed Jun 22, 2025

View reviewed changes

fix: rename common type, remove config gloal import from lib files

25319c8

vercel bot deployed to Preview – admin.ensnode.io June 23, 2025 11:16 View deployment

vercel bot deployed to Preview – ensnode.io June 23, 2025 11:16 View deployment

vercel bot deployed to Preview – ensrainbow.io June 23, 2025 11:17 View deployment

shrugs merged commit 4ee9eb7 into main Jun 23, 2025
7 checks passed

shrugs deleted the fix/ens-deployment-chain branch June 23, 2025 11:19

github-actions bot mentioned this pull request Jun 23, 2025

Release New Version #797

Merged

refactor ens-deployments package (now datasources) & usage #792

refactor ens-deployments package (now datasources) & usage #792

Uh oh!

Conversation

shrugs commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lightwalker-eth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shrugs commented Jun 20, 2025

Uh oh!

lightwalker-eth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shrugs commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lightwalker-eth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lightwalker-eth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shrugs commented Jun 23, 2025

Uh oh!

shrugs commented Jun 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shrugs commented Jun 18, 2025 •

edited

Loading

changeset-bot bot commented Jun 18, 2025 •

edited

Loading

vercel bot commented Jun 18, 2025 •

edited

Loading

shrugs commented Jun 21, 2025 •

edited

Loading