fix(ci): use inline values for the test-ci workflow
#779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves an issue where secret value would not be provided when running the workflow for a branch from forked repo.
🦋 Changeset detectedLatest commit: 41a2824 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The later is not properly replaced during package build
lightwalker-eth
approved these changes
Jun 11, 2025
Member
lightwalker-eth
left a comment
There was a problem hiding this comment.
@tk-o Great updates! 🫡 🚀
| HEALTH_CHECK_TIMEOUT: 60 | ||
| ENSRAINBOW_URL: ${{ secrets.ENSRAINBOW_URL }} | ||
| ENSNODE_PUBLIC_URL: ${{ secrets.ENSNODE_PUBLIC_URL }} | ||
| ENSRAINBOW_URL: https://api.ensrainbow.io |
Member
There was a problem hiding this comment.
Could we add a little comment on these fields we hardcoded identifying why we did that rather than reading from GitHub secrets? It will be helpful to remember for the future why we did it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves an issue where secret value would not be provided when running the workflow for a branch from forked repo.
Example failed workflow run:
https://github.com/namehash/ensnode/actions/runs/15565570790/job/43843278971
Also, this PR fixes references across monorepo dependencies:
The PR replaces PNPM
catalogreferences, as these were not always properly resolved during package build process. Example for^catalog:reference not being replace, while allcatalog:references were replaced correctly for this particularpackage.jsonfile:https://github.com/namehash/ensnode/blob/v0.27.0/packages/ensnode-utils/package.json#L38-L49
NPM code preview:
https://www.npmjs.com/package/@ensnode/utils?activeTab=code
Preview
Related to #776