refactor(ensindexer): improve ENSIndexerConfig #763
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions This way, we can derive config params on already validated config.
🦋 Changeset detectedLatest commit: 7c29440 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
af727c8 to
b4c181c
Compare
tk-o
commented
May 30, 2025
Comment on lines
-157
to
-178
| const derive_isSubgraphCompatible = < | ||
| CONFIG extends Pick< | ||
| ENSIndexerConfig, | ||
| "plugins" | "healReverseAddresses" | "indexAdditionalResolverRecords" | ||
| >, | ||
| >( | ||
| config: CONFIG, | ||
| ): CONFIG & { isSubgraphCompatible: boolean } => { | ||
| // 1. only the subgraph plugin is active | ||
| const onlySubgraphPluginActivated = | ||
| config.plugins.length === 1 && config.plugins[0] === PluginName.Subgraph; | ||
|
|
||
| // 2. healReverseAddresses = false | ||
| // 3. indexAdditionalResolverRecords = false | ||
| const indexingBehaviorIsSubgraphCompatible = | ||
| !config.healReverseAddresses && !config.indexAdditionalResolverRecords; | ||
|
|
||
| return { | ||
| ...config, | ||
| isSubgraphCompatible: onlySubgraphPluginActivated && indexingBehaviorIsSubgraphCompatible, | ||
| }; | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Moved to apps/ensindexer/src/config/derived-params.ts
Contributor
Author
|
Replaced with #765 which also solves for typescript type inference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes refactorings around
ENSIndexerConfigthat allow dropping unnecessary imports and replace them with new derived configuration parameters:ensDeployment.Suggested review order:
apps/ensindexer/src/plugins: all plugins read theensDeploymentdirectly from theappConfigobject.apps/ensindexer/src/plugins/basenames/basenames.plugin.ts:ensDeploymentincludes some ABIs, which I figured will be best not to be shown due to their lengthapps/ensindexer/src/config/types.ts: includingensDeploymentconfig paramapps/ensindexer/src/config/config.schema.ts: moved all derive functionality into its own fileapps/ensindexer/src/config/derived-params.ts: derive functionality forisSubgraphCompatible(moved), andensDeployment(newly added)Resolves: