docs(ensindexer): add extra context around reverse address healing strategies #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lightwalker-eth
approved these changes
May 28, 2025
Member
lightwalker-eth
left a comment
There was a problem hiding this comment.
@tk-o Really fantastic, nice work, thanks 🚀
tk-o
commented
May 28, 2025
Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes additional context behind decisions we made to come up for three distinct label healing strategies for reverse addresses.
Also, this PR replaces logging a console warning with trowing a runtime error to make it very clear that our 100% goal of reverse addresses being healed successfully was not reached and requires attention.
Related to #750