Skip to content

Conversation

@tk-o
Copy link
Contributor

@tk-o tk-o commented May 18, 2025

This PR attempts healing over 35k unhealed reverse addresses that were created by proxy contracts instantiated from:

These 35k reverse addresses could not be successfully healed while handling their relevant NewOwner event, as the ReverseRegistry contract would create reverse address labelhash based on msg.sender which, in this case, is a newly-created wallet proxy contract address. This particular address is not available in the NewOwner event handler.

Thankfully, there's WalletCreated event emitted as the very last event during the given transaction.

Debug info

Feel free to check transaction traces with cast. For example:

cast r 0x946bb98a8b519544077e746be2db59aeab488f91f7421d000ab4cb37091bff2d

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2025

⚠️ No Changeset found

Latest commit: 7419acb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
admin.ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2025 7:35pm
ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2025 7:35pm
ensrainbow.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2025 7:35pm

@tk-o
Copy link
Contributor Author

tk-o commented May 27, 2025

Replaced by #750

@tk-o tk-o closed this May 27, 2025
@lightwalker-eth lightwalker-eth deleted the fix/post-tx-reverse-address-healing branch January 17, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants