Skip to content

Conversation

@notrab
Copy link
Member

@notrab notrab commented May 7, 2025

This attempts to upgrade Astro, Starlight and Tailwind CSS to use the latest versions but there are some regressions with the Starlight theming.

@Y3drk if you have a moment to look through the work you've done on landing pages, I'd appreciate a second set of eyes to make sure nothing was broken there.

Closes #516

@changeset-bot
Copy link

changeset-bot bot commented May 7, 2025

⚠️ No Changeset found

Latest commit: 8b1ee20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
admin.ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 8:12pm
ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 8:12pm
ensrainbow.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 8:12pm

"starlight-llms-txt": "^0.5.0",
"starlight-sidebar-topics": "^0.4.1",
"tailwindcss": "3.4.13"
"tailwindcss": "4.1.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time for us to learn Tailwind V4 🚀

Copy link
Contributor

@tk-o tk-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM 👍

@notrab notrab merged commit 767279c into main May 12, 2025
7 checks passed
@notrab notrab deleted the upgrade-astro-and-starlight branch May 12, 2025 09:35
Copy link
Contributor

@Y3drk Y3drk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notrab
The code looks legit to me.

I also had a look at our LPs and the only thing that broke is the size of the embedded youtube video on ensnode.io.

How it looks on this branch:
image

vs how it should be (current prod):
image

Pretty sure, that min-[780px]:w-[520px] h-[calc(100vw*(9/16))] sm:h-[calc((100vw-222px)*(9/16))] min-[780px]:h-[340px] are the parts that cause the issues. Honestly, I've definitely over-engineered the width/height parts, and we could fix them with some aspect ratio.
Would appreciate if you could have a look at that, but I can also investigate it if you don't have time.

danstarns pushed a commit to danstarns/ensnode that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anchor links in ENSNode docs

4 participants