-
Notifications
You must be signed in to change notification settings - Fork 16
chore: upgrade astro and starlight #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "starlight-llms-txt": "^0.5.0", | ||
| "starlight-sidebar-topics": "^0.4.1", | ||
| "tailwindcss": "3.4.13" | ||
| "tailwindcss": "4.1.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time for us to learn Tailwind V4 🚀
tk-o
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM 👍
Y3drk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@notrab
The code looks legit to me.
I also had a look at our LPs and the only thing that broke is the size of the embedded youtube video on ensnode.io.
vs how it should be (current prod):

Pretty sure, that min-[780px]:w-[520px] h-[calc(100vw*(9/16))] sm:h-[calc((100vw-222px)*(9/16))] min-[780px]:h-[340px] are the parts that cause the issues. Honestly, I've definitely over-engineered the width/height parts, and we could fix them with some aspect ratio.
Would appreciate if you could have a look at that, but I can also investigate it if you don't have time.

This attempts to upgrade Astro, Starlight and Tailwind CSS to use the latest versions but there are some regressions with the Starlight theming.
@Y3drk if you have a moment to look through the work you've done on landing pages, I'd appreciate a second set of eyes to make sure nothing was broken there.
Closes #516