fix(ensadmin): allow displaying networks that have not yet been indexed #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5708662 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shrugs
approved these changes
Apr 30, 2025
tk-o
commented
Apr 30, 2025
Comment on lines
-82
to
-92
| const networksWithoutLastIndexedBlock = Object.entries(networkIndexingStatusByChainId).filter( | ||
| ([, network]) => network.lastIndexedBlock === null, | ||
| ); | ||
|
|
||
| if (networksWithoutLastIndexedBlock.length > 0) { | ||
| throw new Error( | ||
| `Missing last indexed block for some networks with the following chain IDs: ${networksWithoutLastIndexedBlock | ||
| .map(([chainId]) => chainId) | ||
| .join(", ")}`, | ||
| ); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
There's a legit case for a chain not to include the last indexed block value. For example, the chain might be waiting for its turn to be indexed. For the time being, I'll make the viewmodel responsible for mapping proper UI output.
tk-o
commented
Apr 30, 2025
Comment on lines
-368
to
-370
| if (!currentIndexingDate) { | ||
| return <IndexingTimelineFallback />; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Always display a timeline for a chain status. It might be just in the queued indexing phase.
Contributor
Author
|
Resolves #663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows ENSAdmin to display indexing status for chains that have not yet been indexed.
Also, this PR adds sorting the timelines by the indexing start date to allow nice waterfall view of indexing status timelines.
Before
After
URL: https://adminensnodeio-git-fix-468-allow-chains-pending-ba615f-namehash.vercel.app/status?ensnode=https%3A%2F%2Fapi.alpha.green.ensnode.io%2F
Resolves #468