Fix Terser Regex bug Fixes #319 #340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like its always been a bug in nHapi due to the miss understanding of how regex in java vs C#, see below for a brief description of the difference.
The following in java...
does not behave the same as the following in C#:
in java the regular expression pattern must evaluate to a match on the entire candidate where as in C# the regular expression pattern must evaluate to a match within the candidate.
This is what causes the bug described in #319