added palette score provider#32443
Merged
igorkorsukov merged 1 commit intomusescore:masterfrom Mar 3, 2026
Merged
Conversation
7f750f8 to
2578df5
Compare
Eism
reviewed
Mar 3, 2026
| painter->translate(params.xoffset * params.spatium, params.yoffset * params.spatium); // additional offset for element only | ||
|
|
||
| const double sizeRatio = params.spatium / gpaletteScore->style().spatium(); | ||
| const double sizeRatio = params.spatium / element->score()->style().spatium(); |
Contributor
There was a problem hiding this comment.
should there be paletteScoreProvider()->paletteScore()?
2578df5 to
a8972bb
Compare
Eism
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scoreitself is context-dependent and can use some services that depend on the context.The Score for palettes was a global variable—that's a problem. It either should be in the global context, but we currently have a clear separation: services can be either global or contextual. Or it should be made contextual.
This PR makes the Score for palettes contextual.