Fix #32416: Add parenthesis support to "repeat selection" action [4.7.0]#32428
Open
mathesoncalum wants to merge 4 commits intomusescore:4.7from
Open
Fix #32416: Add parenthesis support to "repeat selection" action [4.7.0]#32428mathesoncalum wants to merge 4 commits intomusescore:4.7from
mathesoncalum wants to merge 4 commits intomusescore:4.7from
Conversation
4 tasks
miiizen
approved these changes
Mar 2, 2026
Contributor
|
When repeating a list selection across a barline so that the note is split, only the last note in the tie chain retains its parentheses: Screencast.from.2026-03-03.16-49-21.webmRepeating a list selected parenthesised note in a part causes the note's Style/appearance to become unlinked from the score: Screencast.from.2026-03-03.16-55-06.webmHanding over to @zacjansheski for further testing. |
Contributor
|
The unlinking issue is probably fixed by #32447 |
Contributor
|
Looks good from my end! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #32416
Updated behaviour:
repeatParen.mov
This PR also introduces a unit test for repeated list selections. To do so we need to move the logic into our
Scoreclass (it probably should have been here anyway).Unit test source:
Unit test reference:
