Fix finding endpoint of partial lyrics line#32268
Merged
miiizen merged 1 commit intomusescore:masterfrom Feb 26, 2026
Merged
Conversation
Logic taken from LyricsLayout::createOrRemoveLyricsLine. Here, we find the next available segment to anchor the end of the melisma to. This should mean that the behaviour of inputting partial lyrics lines matches non-partial lyrics lines.
Contributor
|
Tested and approved on Ubuntu 24.04.4 LTS. |
mike-spa
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic taken from LyricsLayout::createOrRemoveLyricsLine. Here, we find the next available segment to anchor the end of the melisma to. This should mean that the behaviour of inputting partial lyrics lines matches non-partial lyrics lines.