Add engineStreamingFreeUpMemory#2268
Merged
botder merged 4 commits intoAug 3, 2021
Merged
Conversation
botder
reviewed
Aug 2, 2021
botder
reviewed
Aug 3, 2021
botder
approved these changes
Aug 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is a wrapper around CStreaming::MakeSpaceFor
The downside is that it isn't accurate, at all. The function works more like "try to free up at least this amount of bytes". It usually ends up freeing everything that isn't currently needed (which, depending on the scenery might be 1-200 megs).
EDIT: Turned out I was calling the wrong function. Re-test before merge!
This function will be useful for scripters when #1677 is introduced (along with a function to get the current streaming mem. usage)