Merged
Conversation
✅ Deploy Preview for multinet-client ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ba27229 to
c604739
Compare
waxlamp
reviewed
Nov 21, 2022
Comment on lines
-210
to
+221
| (upload) => upload.status === 'PENDING' || upload.status === 'STARTED', | ||
| // Find uploads with PENDING, STARTED, or FAILED status and that are less than 15 minutes old | ||
| (upload) => (upload.status === 'PENDING' || upload.status === 'STARTED' || upload.status === 'FAILED') && (new Date().getTime() - new Date(upload.created).getTime() < 15 * 60 * 1000), |
Contributor
There was a problem hiding this comment.
What's the rationale behind the 15 minute cutoff?
Member
Author
There was a problem hiding this comment.
We don't save any state on the browser at the moment. This seemed like a reasonable duration to show the message for. Is there a better way to handle this, maybe using local storage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Depends #247
Closes #160
Closes #224
Give a longer description of what this PR addresses and why it's needed
This adds an error message that shows when an upload has failed. The error will show for 15 minutes and then will hide. It is not dismiss-able by the user, but that could be added as an additional feature.
Provide pictures/videos of the behavior before and after these changes (optional)
Are there any additional TODOs before this PR is ready to go?
No