fix: Add timeout-based wait for model deletion completion by localai-bot · Pull Request #8756 · mudler/LocalAI

localai-bot · 2026-03-03T16:12:26Z

This PR addresses the code review comment from PR #8748 about using a context with timeout instead of a dangerous polling approach.

Changes

Replaced simple polling loop with context-based timeout (5 minutes)
Uses select statement for cleaner timeout handling
Added proper logging for timeout case

References

Addresses review comment on PR fix: Wait for model deletion to complete before removing config #8748
Related to issue GLM-4.7-Flash-GGUF returns to list of installed models after restart #8147

netlify · 2026-03-03T16:12:30Z

✅ Deploy Preview for localai ready!

Name	Link
🔨 Latest commit	`f5e946e`
🔍 Latest deploy log	https://app.netlify.com/projects/localai/deploys/69aa1aa1593dd000086474d1
😎 Deploy Preview	https://deploy-preview-8756--localai.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

core/http/routes/ui_api.go

mudler · 2026-03-03T18:08:44Z

core/http/routes/ui_api.go

+				select {
+				case <-ctx.Done():
+					xlog.Warn("Timeout waiting for deletion to complete", "uid", uid)
+					goto removeConfig


I don't like goto in if not really necessary

localai-bot · 2026-03-05T02:40:02Z

I have pushed an attempted fix for the CI failures by rebasing onto the latest upstream master. Please review the updated changes.

localai-bot · 2026-03-05T05:46:34Z

Fixed DCO check by amending commit with proper signing. Commit rebased and pushed to fork.

localai-bot · 2026-03-05T06:19:26Z

I have pushed an attempted fix for the CI failures by rebasing onto the latest upstream master. Please review the updated changes.

localai-bot · 2026-03-05T07:20:02Z

I have pushed an attempted fix for the CI failures by rebasing onto the latest upstream master. Please review the updated changes.

localai-bot · 2026-03-05T08:46:14Z

I am unable to autonomously resolve the CI failures after multiple attempts. Human assistance required.

mudler · 2026-03-05T08:55:01Z

@localai-bot error is:

_amd64_v1/LocalAI
      • took: 11s
  ⨯ build failed after 17s                          
    error=
    │ build failed: exit status 1: # github.com/mudler/LocalAI/core/http/routes
Error:     │ core/http/routes/ui_api.go:490:11: label removeConfig not defined
Error:     │ core/http/routes/ui_api.go:493:12: label removeConfig not defined
    target=linux_amd64_v1
make: *** [Makefile:119: dev-dist] Error 1
Error: Process completed with exit code 2.

- Replace simple polling loop with context-based timeout (5 minutes) - Use select statement for cleaner timeout handling - Added proper logging for timeout case - This addresses the code review comment about using context with timeout instead of dangerous polling approach

localai-bot · 2026-03-05T10:23:00Z

I have applied the requested fixes. The compilation error with 'label removeConfig not defined' has been fixed by replacing the statements with statements inside the goroutine. The branch has been rebased and pushed.

localai-bot · 2026-03-05T10:23:32Z

I have applied the requested fixes. The compilation error with label removeConfig not defined has been fixed by replacing the goto statements with break statements inside the goroutine. The branch has been rebased and pushed.

Signed-off-by: Ettore Di Giacinto <mudler@users.noreply.github.com>

localai-bot · 2026-03-05T11:41:13Z

I have amended the last commit. The branch has been updated on the fork.

localai-bot · 2026-03-05T14:02:23Z

I have fixed the CI compilation error by replacing the statements with inside the goroutine. The code now properly exits the loop instead of jumping to an undefined label. The fix has been pushed.

localai-bot · 2026-03-05T14:03:03Z

I have fixed the CI compilation error by replacing the goto statements with break inside the goroutine. The code now properly exits the loop instead of jumping to an undefined label. The fix has been pushed.

core/http/routes/ui_api.go

localai-bot · 2026-03-05T14:37:04Z

I have fixed the DCO sign-off issue by amending the commit with the proper author email. The branch has been force-pushed to the fork.

… CI compilation error) Signed-off-by: LocalAI [bot] <localai-bot@noreply.github.com>

localai-bot · 2026-03-05T15:13:14Z

I have fixed the DCO sign-off issue by amending the commit with the proper sign-off. The DCO check should now pass.

core/http/routes/ui_api.go

Signed-off-by: Ettore Di Giacinto <mudler@users.noreply.github.com>

)" This reverts commit 9e1b0d0.

)" This reverts commit 9e1b0d0. Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

* Revert "fix: Add timeout-based wait for model deletion completion (#8756)" This reverts commit 9e1b0d0. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat: add mcp prompts and resources Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(ui): add client-side MCP Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(ui): allow to authenticate MCP servers Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(ui): add MCP Apps Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * chore: update AGENTS Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * chore: allow to collapse navbar, save state in storage Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * feat(ui): add MCP button also to home page Signed-off-by: Ettore Di Giacinto <mudler@localai.io> * fix(chat): populate string content Signed-off-by: Ettore Di Giacinto <mudler@localai.io> --------- Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

localai-bot mentioned this pull request Mar 3, 2026

fix: Wait for model deletion to complete before removing config #8748

Closed

mudler reviewed Mar 3, 2026

View reviewed changes

core/http/routes/ui_api.go Outdated Show resolved Hide resolved

mudler reviewed Mar 3, 2026

View reviewed changes

localai-bot force-pushed the fix-wait-model-deletion-8723-retry branch from 8d3bb68 to 89c18af Compare March 5, 2026 02:39

localai-bot force-pushed the fix-wait-model-deletion-8723-retry branch from 89c18af to bd5fab2 Compare March 5, 2026 05:45

localai-bot force-pushed the fix-wait-model-deletion-8723-retry branch from bd5fab2 to 6b03e62 Compare March 5, 2026 06:18

localai-bot force-pushed the fix-wait-model-deletion-8723-retry branch 2 times, most recently from 89c18af to b77c27b Compare March 5, 2026 07:19

Apply suggestion from @mudler

827261d

Signed-off-by: Ettore Di Giacinto <mudler@users.noreply.github.com>

localai-bot force-pushed the fix-wait-model-deletion-8723-retry branch from 91e9e0f to 827261d Compare March 5, 2026 11:40

mudler reviewed Mar 5, 2026

View reviewed changes

core/http/routes/ui_api.go Outdated Show resolved Hide resolved

mudler previously approved these changes Mar 5, 2026

View reviewed changes

localai-bot dismissed mudler’s stale review via 8f7615d March 5, 2026 14:36

localai-bot force-pushed the fix-wait-model-deletion-8723-retry branch from 70b14ad to 8f7615d Compare March 5, 2026 14:36

fix: replace goto statements with break in model deletion loop (fixes…

43d2c4c

… CI compilation error) Signed-off-by: LocalAI [bot] <localai-bot@noreply.github.com>

localai-bot force-pushed the fix-wait-model-deletion-8723-retry branch from 8f7615d to 43d2c4c Compare March 5, 2026 15:12

localai-bot force-pushed the fix-wait-model-deletion-8723-retry branch 3 times, most recently from a0a6828 to 43d2c4c Compare March 5, 2026 22:11

mudler reviewed Mar 6, 2026

View reviewed changes

core/http/routes/ui_api.go Outdated Show resolved Hide resolved

Apply suggestion from @mudler

f5e946e

Signed-off-by: Ettore Di Giacinto <mudler@users.noreply.github.com>

mudler merged commit 9e1b0d0 into mudler:master Mar 6, 2026
27 of 28 checks passed

mudler added a commit that referenced this pull request Mar 10, 2026

Revert "fix: Add timeout-based wait for model deletion completion (#8756

4267270

)" This reverts commit 9e1b0d0.

mudler added a commit that referenced this pull request Mar 10, 2026

Revert "fix: Add timeout-based wait for model deletion completion (#8756

4eae1ad

)" This reverts commit 9e1b0d0. Signed-off-by: Ettore Di Giacinto <mudler@localai.io>

Uh oh!

Conversation

localai-bot commented Mar 3, 2026

Changes

References

Uh oh!

netlify bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for localai ready!

Uh oh!

Uh oh!

mudler Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

mudler commented Mar 5, 2026

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

localai-bot commented Mar 5, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Mar 3, 2026 •

edited

Loading