Skip to content

Conversation

@hoefling
Copy link

@hoefling hoefling commented Feb 7, 2020

This PR adds PEP 561 compatibility to msgpack.

I keep the type stubs from this PR for development with msgpack. The idea is to make them available to everyone by adding them to the distribution. There are no changes to the msgpack code itself, the stub is completely separated from the real code.

If you are against adding type stubs, I'd still be grateful for a review that would improve the stub quality - maybe you have a good advice on how to deal with the remaining Any types.

@hoefling hoefling requested a review from methane February 7, 2020 23:17
@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #404 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
- Coverage   88.06%   87.94%   -0.12%     
==========================================
  Files           5        5              
  Lines         846      846              
==========================================
- Hits          745      744       -1     
- Misses        101      102       +1
Impacted Files Coverage Δ
msgpack/fallback.py 88.81% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2849f55...c7f6c8b. Read the comment docs.

@methane methane mentioned this pull request Jan 27, 2021
@methane methane changed the title Add PEP 561 compatibility Add type stubs. Jan 27, 2021
@methane
Copy link
Member

methane commented Jan 27, 2021

I'm sorry, but I am not an expert of typing and I can not maintain it.
I don't want to merge I can not maintain. So I don't merge this pull request anytime soon.

I will drop Python 2 support completely in next major version (in 2021 or 2022). I will reconsider this after it.

@hoefling
Copy link
Author

@methane no worries, I see that someone has created a stubs-only package recently: https://github.com/sbdchd/msgpack-types. So this is not an issue anymore, thus closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants