Skip to content

Conversation

@gfx
Copy link
Member

@gfx gfx commented Apr 30, 2019

Completely re-written the implementation in TypeScript based on the original (@uupaa san's), including lots of bug fixes and performance improvement.

Test Coverage

as of 950e05a

=============================== Coverage summary ===============================
Statements   : 92.05% ( 382/415 )
Branches     : 88.24% ( 45/51 )
Functions    : 95.74% ( 45/47 )
Lines        : 91.77% ( 368/401 )
================================================================================

Benchmark compared to msgpack-lite

Benchmark on NodeJS/v12.1.0

operation op ms op/s
buf = Buffer.from(JSON.stringify(obj)); 509600 5001 101899
buf = JSON.stringify(obj); 837700 5000 167540
obj = JSON.parse(buf); 346700 5001 69326
buf = require("msgpack-lite").encode(obj); 353000 5000 70600
obj = require("msgpack-lite").decode(buf); 272500 5000 54500
buf = require("@msgpack/msgpack").encode(obj); 368800 5001 73745
buf = Buffer.from(require("@msgpack/msgpack").encode(obj)); 353100 5001 70605
obj = require("@msgpack/msgpack").decode(buf); 287500 5001 57488

@gfx gfx changed the title [WIP] Rewrite implementation with TypeScript Rewrite implementation with TypeScript May 1, 2019
@gfx gfx changed the title Rewrite implementation with TypeScript Rewrite implementation in TypeScript May 2, 2019
@gfx gfx merged commit cba5ecf into master May 2, 2019
@gfx gfx deleted the rewrite branch May 2, 2019 02:05
@gfx gfx restored the rewrite branch May 2, 2019 05:21
@gfx gfx deleted the rewrite branch May 2, 2019 05:22
gfx pushed a commit that referenced this pull request Aug 10, 2021
Bumps [buffer](https://github.com/feross/buffer) from 5.7.1 to 6.0.3.
- [Release notes](https://github.com/feross/buffer/releases)
- [Commits](feross/buffer@v5.7.1...v6.0.3)

---
updated-dependencies:
- dependency-name: buffer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants