Skip to content

Conversation

@s-rigaud
Copy link
Contributor

Description

By Js standard Promise is a generic so not defining a type inside arrows ends up to be Promise<Any>. I just tried to improve the typing for some methods.

@github-actions
Copy link

github-actions bot commented Jan 13, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.52
79.1
339.52
79.1
+0 B
+0 B
WebGPU 490.81
136.38
490.81
136.38
+0 B
+0 B
WebGPU Nodes 490.27
136.28
490.27
136.28
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.41
112.15
465.41
112.15
+0 B
+0 B
WebGPU 561.38
152.09
561.38
152.09
+0 B
+0 B
WebGPU Nodes 516.77
141.66
516.77
141.66
+0 B
+0 B

@s-rigaud s-rigaud force-pushed the docs-improve-Promise-typing branch 2 times, most recently from 0d0dcc2 to 175a5fd Compare January 13, 2025 15:31
@s-rigaud s-rigaud force-pushed the docs-improve-Promise-typing branch 2 times, most recently from 4f14ee0 to 7f769e4 Compare January 13, 2025 20:19
@Mugen87 Mugen87 added this to the r173 milestone Jan 13, 2025
@Mugen87 Mugen87 merged commit acc17c6 into mrdoob:dev Jan 13, 2025
12 checks passed
@s-rigaud s-rigaud deleted the docs-improve-Promise-typing branch January 22, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants