Allow UDL to define Enums with objects#2412
Merged
mhammond merged 1 commit intomozilla:mainfrom Jan 21, 2025
Merged
Conversation
jplatte
reviewed
Jan 21, 2025
| assert(false) | ||
| } | ||
|
|
||
| switch getAnimalEnum(animal: Animal.cat) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| switch getAnimalEnum(animal: Animal.cat) { | |
| switch getAnimalEnum(animal: Animal.cat) { |
bendk
approved these changes
Jan 21, 2025
| let type_ = ci.resolve_type_expression(&self.type_)?; | ||
| if let Type::Object { .. } = type_ { | ||
| bail!("Objects cannot currently be used in enum variant data"); | ||
| } |
Contributor
There was a problem hiding this comment.
I love these PRs, we just need to delete the code that's stopping users from doing the things they want.
proc-macros already support this, as verified by new tests. Fixes mozilla#1372
1b553c6 to
9df9cbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proc-macros already support this, as verified by new tests.
Fixes #1372