This repository was archived by the owner on Sep 2, 2025. It is now read-only.
feat: Add addr feature#27
Closed
larseggert wants to merge 1 commit into
Closed
Conversation
`interface_and_mtu` is now behind the default-on `addr` feature. The point of this is to introduce `interface_and_mtu_of_socket`, which operates on an existing `UdpSocket`. That means we can avoid `connect`, which is blocklisted by Firefox for dependencies. The downside is that we would need to pass in the actual `UdpSocket` to the neqo transport code, which is probably a huge pain...
Member
Under the assumption that the socket MTU is reasonably static, Edit: Problem is, we don't know the remote IP address at that point. |
Collaborator
Author
|
We also need to get the MTU for each path, not just at creation time. There is a feature request for |
Collaborator
Author
|
Closing this in favor of #29. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interface_and_mtuis now behind the default-onaddrfeature.The point of this is to introduce
interface_and_mtu_of_socket, which operates on an existingUdpSocket. That means we can avoidconnect, which is blocklisted by Firefox for dependencies.The downside is that we would need to pass in the actual
UdpSocketto the neqo transport code, which is probably a huge pain...