Skip to content

Clarify how other browsers handle the BSS key#2129

Merged
rebloor merged 3 commits into
masterfrom
bss-warning-fix
Aug 29, 2025
Merged

Clarify how other browsers handle the BSS key#2129
rebloor merged 3 commits into
masterfrom
bss-warning-fix

Conversation

@dotproto

@dotproto dotproto commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Chrome stopped logging a warning when the browser_specific_settings key is present in an extensions' manifest. This PR updates the note in our add-on ID docs to clarify Chrome and Safari behavior when parsing this object.

Fixes #2126

@dotproto dotproto requested a review from rebloor July 22, 2025 23:41

@rebloor rebloor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotproto I'm wondering whether we need to re-factor this content to make clear that this applies to both manifest V2 and V3 (where you have to specify an ID and therefore include browser_specific_settings). In addition, we should probably mention this in the cross browser discussion e.g. https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Build_a_cross_browser_extension#manifest_keys

Comment thread src/content/documentation/develop/extensions-and-the-add-on-id.md Outdated
@dotproto

Copy link
Copy Markdown
Contributor Author

@rebloor are we good to merge this change?

@rebloor

rebloor commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

@dotproto if you're happy that we don't need to do anything re-my comment, then yes.

I'm wondering whether we need to re-factor this content to make clear that this applies to both manifest V2 and V3 (where you have to specify an ID and therefore include browser_specific_settings). In addition, we should probably mention this in the cross-browser discussion e.g., https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Build_a_cross_browser_extension#manifest_keys

@dotproto

Copy link
Copy Markdown
Contributor Author

Ah, sorry I overlooked that message. Yes, I agree that a refactor would be ideal. Let's land this change and address the refactor in a separate PR. I'll create an issue for that in a moment.

@rebloor rebloor merged commit 0a7fdc9 into master Aug 29, 2025
1 check passed
@rebloor rebloor deleted the bss-warning-fix branch August 29, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove mention of Chrome warning on BSS in the add-on ID docs

2 participants