wasapi: Reduce timeout threshold#447
Merged
Merged
Conversation
Collaborator
|
r+ let's land this soon to see if it makes things better. |
|
Is this still relevant fix for mozilla? I found that it often reports an error and dies after waking up from sleep in a few programs that use cubeb with timeout counter < 5. Alternatively, #542 would probably fix that, but it seems there were no activity there for quite some time. |
Collaborator
|
I've commented in #542: rebased the patch on top of current master branch, and kicked off a couple CI runs: cubeb's own CI, that can now run Windows tests, and Firefox's CI, that's very unforgiving because it runs quite a lot of tests and quite a number of different workloads, on different OS. I think we completely forgot about it, sorry about that, let's get a solution merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See bug 1465617 comment 20 for the background for this change.
In short the Firefox shutdown hang monitor also times out after 5 seconds by default, so cubeb has to timeout faster or confusing almost-coherent stacks show up in crash-stats.