Skip to content

Bug 2016766: [ci full] updates the return type of methodrecordEventOrThrow() in a Nimbus Android SDK#7223

Merged
yashikakhurana merged 7 commits intomainfrom
bug_2016766
Feb 17, 2026
Merged

Bug 2016766: [ci full] updates the return type of methodrecordEventOrThrow() in a Nimbus Android SDK#7223
yashikakhurana merged 7 commits intomainfrom
bug_2016766

Conversation

@yashikakhurana
Copy link
Copy Markdown
Contributor

@yashikakhurana yashikakhurana commented Feb 13, 2026

This PR updates the return type of methodrecordEventOrThrow() in a Nimbus Android SDK

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

freshstrangemusic
freshstrangemusic previously requested changes Feb 14, 2026
View reviewed changes
Comment thread components/nimbus/android/src/main/java/org/mozilla/experiments/nimbus/Nimbus.kt Outdated
Comment thread components/nimbus/android/src/main/java/org/mozilla/experiments/nimbus/NimbusInterface.kt Outdated
@yashikakhurana yashikakhurana removed the request for review from freshstrangemusic February 17, 2026 17:09
@yashikakhurana yashikakhurana added this pull request to the merge queue Feb 17, 2026
Merged via the queue into main with commit 54a66e8 Feb 17, 2026
58 checks passed
@yashikakhurana yashikakhurana deleted the bug_2016766 branch February 17, 2026 20:12
Almaju pushed a commit to Almaju/application-services that referenced this pull request Mar 9, 2026
@yashikakhurana @freshstrangemusic @Almaju
Bug 2016766: [ci full] updates the return type of method`recordEventO…
ff4b9f6 
…rThrow()` in a Nimbus Android SDK (mozilla#7223)

* feat(nimbus): New method to record event

* feat(nimbus): Use completablejob

* feat(nimbus): Use completablejob

* Update components/nimbus/android/src/main/java/org/mozilla/experiments/nimbus/NimbusInterface.kt

Co-authored-by: Beth Rennie <beth@brennie.ca>

* feat(nimbus): Use completablejob

* feat(nimbus): Use completablejob

---------

Co-authored-by: Beth Rennie <beth@brennie.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freshstrangemusic freshstrangemusic freshstrangemusic approved these changes

+1 more reviewer

@marcin-kozinski marcin-kozinski marcin-kozinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yashikakhurana @freshstrangemusic @marcin-kozinski