[Task]: Support manual action and apply policy from Cinder investigate entity page

[eviljeff]

Description

From a page like https://mozilla-staging.cinderapp.com/investigate/amo_addon/{id} you can view an entity in Cinder. There's a 3-dot menu at the right hand side of the page that has options to take "Manual Action", and "Apply policy" - they are pretty similar: the former allows you to select an enforcement action that should be taken on the entity; the latter applies polic[y|ies], that would in turn have enforcement actions.

Acceptance Criteria

• Manual action results in a decision where the enforcement action being applied to the entity (e.g. Addon) in AMO. (Invalid actions for that entity would obviously be ignored)
• Apply policy results in a decision with policies, where the enforcement action of the polic[y|ies] are applied to the entity (e.g. Addon) in AMO. (Invalid actions, and selecting multiple policies with conflicting actions are expected to be ignored)
• non-Addon entities should work too.

┆Issue is synchronized with this Jira Task

[eviljeff]

I filed this mainly so the connected PR can be QA'd.

[ioanarusiczki]

Tested scenarios:

1. I started with a failed test but expected to fail because the policy has a reject version enforcement action set and I think only the disable is expected to happen. ✅

https://mozilla-staging.cinderapp.com/investigate/amo_addon/642535/pastDecisions

2. disabled an addon without having a report attached , it can be done using https://mozilla-staging.cinderapp.com/investigate/amo_addon/{id}

• sent the developer appeal
• the appeal flagged for hr the addon - in the Manual Review queue
• granted developer appeal (force-enabled + appeal checked)

https://mozilla-staging.cinderapp.com/investigate/amo_addon/642537/pastDecisions
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/642537

3. repeated with a promoted addon , same str as above + the extra approval from the 2nd level decisions queue

2+ 3 should be ✅

4. An addon with a report attached is with ❓

The job is still open in Cinder https://mozilla-staging.cinderapp.com/job/769a47c7-e26e-4e02-8f2b-9d76aac53e39
The appeal shows up without the report in the dsa section https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/642538

Another example
Cinder job stays open https://mozilla-staging.cinderapp.com/job/bcd437df-3ee6-4b6f-a832-1b9c249d2ffa while the content is disabled on amo https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/642540

5. An unlisted approved version disabled from Cinder
   is not found https://mozilla-staging.cinderapp.com/investigate/amo_addon/642534 -> could indicate the unlisted are not in scope ✅

6. Also worked for rejecting listing content ✅
   https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-content/642543
   And the job is open in this case too https://mozilla-staging.cinderapp.com/job/02d49869-413e-4f51-a2b1-c4bdc54b9d5d until the developer confirms from dev hub, confirmation shows up inside the job and if resolved with approve it exits the queue.

Still to try

• scenario 2 for content rejections - when the developer sends an appeal using the url from the email sent
• with non-addon content.

[eviljeff]

An addon with a report attached is with ❓

reports are not attached to entities, they are attached to jobs in queues. Manual actions are applied to the entity, so it's expected that any jobs are unaffected.

[ioanarusiczki]

• scenario 2 for content rejections - when the developer sends an appeal using the url from the email sent
  https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/642545
  the appeal is closed, the initial job (when addon was uploaded) is still open

• with non-addon content.
  I've sent for each a report so I didn't search on amo for their ids etc -> jobs with abuse reports stay open in queues - which is expected (explained above why)

deleted rating https://mozilla-staging.cinderapp.com/investigate/amo_rating/575492/pastDecisions
deleted collection https://mozilla-staging.cinderapp.com/investigate/amo_collection/5499084/pastDecisions
user https://mozilla-staging.cinderapp.com/investigate/amo_user/10642146/pastDecisions
theme https://mozilla-staging.cinderapp.com/investigate/amo_addon/642128/pastDecisions

[ioanarusiczki]

This also worked from rhs kebab menu -> Take manual action

AMO disable addon

https://reviewers.addons.allizom.org/en-US/reviewers/review/2254857

AMO reject listing content

https://reviewers.addons.allizom.org/en-US/reviewers/review/2254858

I tried a version reject too - same as before with Apply a policy, that is not working (or not yet)

[eviljeff]

https://reviewers.addons.allizom.org/en-US/reviewers/review/2254858

I tried a version reject too - same as before with Apply a policy, that is not working (or not yet)

Version rejection is not supported from Cinder - there is no UI to select which version(s) the action/policy is being applied to.

[ioanarusiczki]

Ah ok, so it's going to continue to work from AMO rev tools.

A user ban with Take manual action also worked , it went to 2nd level approvals

for https://mozilla-staging.cinderapp.com/investigate/amo_user/11689006/pastDecisions