Add support for Sanic 21+#71
Merged
relud merged 2 commits intomozilla-services:mainfrom Aug 18, 2022
relud:sanic-21-22
Merged
Conversation
relud
commented
Aug 17, 2022
| @@ -0,0 +1,7 @@ | |||
| # these are constrained by the files in tests/constraints/*.txt | |||
Member
Author
There was a problem hiding this comment.
sanic 20.* needs a separate requirements file to remove the sanic-testing requirement.
Member
Author
|
r? @jwhitlock |
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 97.80% 97.81% +0.01%
==========================================
Files 18 18
Lines 593 596 +3
Branches 97 98 +1
==========================================
+ Hits 580 583 +3
Misses 9 9
Partials 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jwhitlock
previously approved these changes
Aug 18, 2022
| @pytest.fixture(scope="function") | ||
| def app(): | ||
| app = Sanic("dockerflow") | ||
| app = Sanic(f"dockerflow-{uuid.uuid4().hex}") |
Member
There was a problem hiding this comment.
nice way to generate unique app IDs for tests!
| yield test_client | ||
| finally: | ||
| s.close() | ||
| return SanicTestClient(app) |
Member
Author
|
@jwhitlock suggestion applied, needs your review again, and I don't know that i'll be able to merge it as I don't have write access to this repo. |
jwhitlock
approved these changes
Aug 18, 2022
Member
jwhitlock
left a comment
There was a problem hiding this comment.
Thanks! I've given you Write access, see if you can merge now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #70