Skip to content

Moveit_cpp Tutorial#64

Closed
MarqRazz wants to merge 3 commits into
moveit:mainfrom
MarqRazz:pr-moveit_cpp_tutorial
Closed

Moveit_cpp Tutorial#64
MarqRazz wants to merge 3 commits into
moveit:mainfrom
MarqRazz:pr-moveit_cpp_tutorial

Conversation

@MarqRazz

@MarqRazz MarqRazz commented Mar 18, 2021

Copy link
Copy Markdown
Contributor

Port of moveit_cpp tutorial to ROS2. This addresses issue #20

To launch the tutorial run:
`ros2 launch moveit2_tutorials moveit_cpp_tutorial.launch.py

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Convert launch files to ROS2
  • Cleanup demo and add documentation

@MarqRazz MarqRazz changed the title Moveit_cpp Tutorial [WIP] Moveit_cpp Tutorial Mar 29, 2021
@henningkayser henningkayser self-assigned this Mar 30, 2021
@henningkayser henningkayser self-requested a review March 30, 2021 14:27
@MarqRazz MarqRazz requested review from JafarAbdi, auman66, cmelliott2 and henningkayser and removed request for henningkayser March 31, 2021 13:11

@JafarAbdi JafarAbdi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work with the main branch of moveit2

@@ -0,0 +1,18 @@
panda_arm_controller:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This's for the old ros2_control, we're depending on the master branch now, see run_moveit_cpp.launch.py

@@ -0,0 +1,15 @@
controller_names:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the one from moveit_resources

@@ -0,0 +1,19 @@
fake_joint_driver_node:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This's no longer needed

planning_pipeline: ompl
max_velocity_scaling_factor: 1.0
max_acceleration_scaling_factor: 1.0
moveit_cpp_tutorial:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this file to moveit_resources .?

parameters=[robot_description])

# Fake joint driver
fake_joint_driver_node = Node(package='fake_joint_driver',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer depend on fake_joint_driver see

@JafarAbdi

Copy link
Copy Markdown
Member

Should we remove run_moveit_cpp from the MoveIt2 repo and point users to this page .?

@MarqRazz

Copy link
Copy Markdown
Contributor Author

Changed were added in #69

@MarqRazz MarqRazz closed this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants