Skip to content

Move Group C++ Interface#62

Closed
MarqRazz wants to merge 9 commits into
moveit:mainfrom
MarqRazz:pr-move_group_interface_tutorial
Closed

Move Group C++ Interface#62
MarqRazz wants to merge 9 commits into
moveit:mainfrom
MarqRazz:pr-move_group_interface_tutorial

Conversation

@MarqRazz

@MarqRazz MarqRazz commented Mar 10, 2021

Copy link
Copy Markdown
Contributor

This is the initial port of the Move Group C++ Interface tutorial and addresses #2 . This tutorial is very similar to moveit2_demo_nodes/run_move_group which is where I grabbed the launch files.

To test this code run the following:
ros2 launch moveit2_tutorials move_group.launch.py
ros2 launch moveit2_tutorials move_group_interface_tutorial.launch.py

Items that I still need to address:

  • Clean up code and get the markers working with rviz_visual_tools until moveit_visual_tools is ported
  • Generate the webpage and see how it looks
  • Add more documentation
  • Get the collision scene examples working better (they tend to fail to plan)
  • Add to the readme and webpage that you need xterm installed

Checklist

@MarqRazz MarqRazz changed the title Move Group C++ Interface [WIP] Move Group C++ Interface Mar 31, 2021
Comment on lines +14 to +16
install(DIRECTORY config
DESTINATION share/${PROJECT_NAME}
)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the YAML files from moveit_resources

Suggested change
install(DIRECTORY config
DESTINATION share/${PROJECT_NAME}
)

parameters=[robot_description])

# Fake joint driver
fake_joint_driver_node = Node(package='fake_joint_driver',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We replaced this node with the one from ros2_control see

@MarqRazz

Copy link
Copy Markdown
Contributor Author

Changes were added in #69

@MarqRazz MarqRazz closed this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants