docs: update RFC-001 progress and split Phase 8#528
docs: update RFC-001 progress and split Phase 8#528moonD4rk wants to merge 1 commit intofeat/v2-hbd-architecturefrom
Conversation
- Mark Phase 1-7 as Done with PR references - Split Phase 8 into 8a (interface), 8b (Chromium impl), 8c (Firefox impl), 8d (PickBrowsers) for incremental delivery - Resolve Open Questions #2 (Firefox IV-length detection) and #3 (sort direction) - Add Known Issues section tracking #522 and #525 - Update status to In Progress (Phase 8a)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/v2-hbd-architecture #528 +/- ##
=========================================================
Coverage 48.47% 48.47%
=========================================================
Files 42 42
Lines 1510 1510
=========================================================
Hits 732 732
Misses 693 693
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates RFC-001 (architecture refactoring plan) to reflect current implementation progress and to break Phase 8 into smaller deliverables for incremental rollout.
Changes:
- Updates RFC status/last-updated date and marks Phases 1–7 as done (with PR references where applicable).
- Splits Phase 8 into sub-phases (8a–8d) to separate interface design, engine implementations, and platform discovery work.
- Resolves previously open questions and adds a “Known Issues” tracker section.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ### Known Issues (tracked) | ||
|
|
||
| - **#522**: TimeEpoch/TimeStamp conditional heuristic removed — needs investigation |
There was a problem hiding this comment.
The note for #522 says “TimeEpoch/TimeStamp conditional heuristic removed”, but the current implementation in utils/typeutil/typeutil.go still contains the heuristic/magic-number overflow handling and time.Local usage. Update this bullet to accurately reflect the issue being tracked (or the desired change), so the RFC doesn’t imply the fix has already landed.
| - **#522**: TimeEpoch/TimeStamp conditional heuristic removed — needs investigation | |
| - **#522**: TimeEpoch/TimeStamp conditional heuristic and `time.Local`/magic-number handling in `utils/typeutil/typeutil.go` to be refactored — pending |
| - **8b** and **8c** implement the two browser engines (can be done in parallel) | ||
| - **8d** adds platform-specific browser discovery (depends on 8b+8c) | ||
|
|
||
| Additional PRs merged during implementation: |
There was a problem hiding this comment.
The section title says “Additional PRs merged during implementation”, but #525 is an issue (LevelDB parsing bug) rather than a PR. Consider either renaming this subsection to include issues too, or moving #525 into a separate “Additional issues” list to avoid mislabeling.
| Additional PRs merged during implementation: | |
| Additional PRs and issues during implementation: |
Summary
Update RFC-001 to reflect current implementation progress and plan for Phase 8.
Changes
In Progress (Phase 8a)