This repository was archived by the owner on Jun 5, 2020. It is now read-only.
Making it compatible with ngStrictDi and updating Moment.js #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 @monterail-deploy |
Contributor
|
@mrodrigues could you please update this PR so there will be no conflicts? I will merge this. |
Author
|
Done, @jandudulski :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've ran into a problem when using this lib, an app I'm working on has the
ngStrictDimode activated and it'll raise an exception if any provider, controller or directive don't have it's dependencies explicitly annotated.I'm also allowing more recent versions of Moment.js, since it was conflicting with some libs I'm using. I've tested everything with the most recent version and it seems to be working perfectly.