Conversation
There was a problem hiding this comment.
should be
extern char const * const name [] = { ... }
and remove the casts. constant pointers to constant characters.
What you have is mutable pointers to constant void.
constant pointers are generally more efficient and more secure and less error-prone.
There was a problem hiding this comment.
Must this be strcmp?
Not an integer or enum, or a string with a length?
strcmp is slow.
There was a problem hiding this comment.
nit: one space after return instead of two
There was a problem hiding this comment.
Please figure out how to use qsort or std::sort here, instead of inlining it.
If you need inlining for perf, take an existing qsort and change it to a slightly ugly but fair enough macro. It's been done, it isn't hard, and it can be argued for perf.
There was a problem hiding this comment.
nit: space between function name and the opening paren to call it.
There was a problem hiding this comment.
nit: spaces around binary operators: low = mid + 1
but really, delete all this code anyway and use qsort or std::sort or a macro.
e131798 to
043c2bf
Compare
|
@monojenkins build |
043c2bf to
e1eb9ee
Compare
e1eb9ee to
8a82b4f
Compare
- Implementing QCalls on mono - Use QCalls on ICU Shim implementation Fixes dotnet/runtime#36449
8a82b4f to
63cf4f0
Compare
|
@monojenkins build failed |
!! This PR is a copy of dotnet/runtime#37670, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
- Implementing QCalls on mono
Fixes #dotnet/runtime#36449