Simplify RequestMessage class hierarchy #1787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove EncodingMetadata abstraction and pull the remains into CommandMessage * Pull the writeDocuments method into CommandMessage and simplify its parameters JAVA-5944
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the RequestMessage class hierarchy by removing the EncodingMetadata abstraction layer and consolidating its functionality directly into CommandMessage. The changes eliminate unnecessary indirection and streamline the encoding process for MongoDB Wire Protocol messages.
Key Changes:
- Remove the EncodingMetadata class and its associated methods from RequestMessage
- Simplify the encoding method signature by removing metadata return value
- Move document writing logic directly into CommandMessage with a more specific implementation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| RequestMessage.java | Removes EncodingMetadata class and simplifies encoding method signature |
| CompressedMessage.java | Updates encoding method to match new signature without metadata return |
| CommandMessage.java | Adds direct tracking of first document position and includes document writing logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
driver-core/src/main/com/mongodb/internal/connection/CommandMessage.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/CommandMessage.java
Show resolved
Hide resolved
…ssage.java Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5944