Fails with node.js 9.6.0+

[papandreou]

Everything works fine with 9.5.0 and below, but on 9.6.0 a bunch of the tests fail with:

  1) Mitm via Http.request as request must emit request on Mitm:
     Uncaught TypeError: ParserIncomingMessage is not a constructor
      at HTTPParser.parserOnHeadersComplete (_http_common.js:81:21)
      at socketOnData (_http_server.js:472:20)
      at Socket.emit (events.js:125:13)
      at addChunk (_stream_readable.js:269:12)
      at readableAddChunk (_stream_readable.js:256:11)
      at Socket.Readable.push (_stream_readable.js:213:10)
      at InternalSocket.onread (net.js:590:20)
      at InternalSocket.readData (/home/andreas/work/node-mitm/lib/internal_socket.js:109:13)
      at InternalSocket.emit (events.js:125:13)
      at addChunk (_stream_readable.js:269:12)
      at readableAddChunk (_stream_readable.js:256:11)
      at InternalSocket.Readable.push (_stream_readable.js:213:10)
      at /home/andreas/work/node-mitm/lib/internal_socket.js:57:40
      at process._tickCallback (internal/process/next_tick.js:150:11)

[papandreou]

Seems like this commit is the culprit: nodejs/node@c247cb02a1

[fyhao]

Yes, thanks, I encountered the same issue here. May I know when will this issue fixed and merged into master?

[papandreou]

@fyhao, I've fixed it in #49 and published my mitm-papandreou fork. You can switch to that if you're in a hurry.

[dbellizzi]

This happens in node 8.12.0 as well, which was released yesterday.

[shudingbo]

This happens in node 8.12.0 as well, which was released yesterday.

me too,when upgrade 8.12.0

[papandreou]

While you're waiting, you can switch to the mitm-papandreou package, which includes this fix.

[moll]

On it! Checking out @papandreou's work and ensuring it works on v10 as well. Hope to get a fix out tomorrow.

[moll]

Thanks again, @papandreou, and others, for the Node v9.6+ debug help. While I was checking that out, I went ahead and fixed Node v10 and v8.12 as well as they seemed to introduce a few other incompatibilities.

I'll cut a release once I've heard some of you confirm that the master branch works on your machine with a real project. Doing the same myself.