polish(frontend): technical review QA #5097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🚀 Frontend Deploy
|
Contributor
Frontend previewsLast deployed commit is 77fbfee0072610d739246f56ce8dfc16fa8c0cd8
|
tdgao
reviewed
Jan 20, 2026
| if (versionDataCache.value.has(versionId)) continue | ||
| versionDataCache.value.set(versionId, { files: new Map(), loading: true }) | ||
| try { | ||
| // TODO: switch to api-client once truman's vers stuff is merged |
Contributor
There was a problem hiding this comment.
could refactor to use the api client if u feel like it
| </template> | ||
|
|
||
| <style scoped> | ||
| /* .floating-panel-enter-active, |
Member
Author
There was a problem hiding this comment.
intended - dont want to remove as in the future i will redo the animations, for now will just leave it like this for reference
Prospector
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.