Overriding with context manager (one and multiple providers)#53
Merged
lesnik512 merged 8 commits intomodern-python:mainfrom Jul 15, 2024
Merged
Conversation
Member
|
@nightblure looks great, thanks! |
lesnik512
reviewed
Jul 15, 2024
Contributor
Author
Member
Contributor
Author
|
thanks for the review! corrected according to your comments, please take a look |
Contributor
Author
|
hmm, there is still a question about updating the documentation. I can try to add the relevant sections myself if you allow, or you will do this |
Member
|
@nightblure would be great if you'll add docs as well, but it's up to you. Anyway, thank you for your contribution! |
Contributor
Author
ok I'll try to do it. within the current MR or separate? |
Member
|
@nightblure better in separate, I'll merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I implement two little features for ease of use during tests: