Skip to content

Conversation

@sir1st-inc
Copy link
Contributor

allow user add custom modelscope model func

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @sir1st-inc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant extensibility feature by allowing users to define and register their own custom functions for fetching ModelScope models. This enhancement provides greater flexibility for integrating with diverse model sources or implementing specialized download behaviors, without requiring modifications to the core library. The change primarily involves adding a global hook mechanism and exposing functions to manage this hook, ensuring that the fetch_modelscope_model function can seamlessly incorporate user-defined logic.

Highlights

  • Custom ModelScope Fetching Mechanism: A global registry (_CUSTOM_MODELSCOPE_FETCHER) has been implemented to allow external code to register a custom function that will be used for fetching ModelScope models.
  • Public API for Custom Fetchers: Two new functions, register_fetch_modelscope_model and reset_fetch_modelscope_model, have been exposed in the public API, providing clear entry points for users to manage their custom ModelScope fetchers.
  • Conditional Model Fetching Logic: The existing fetch_modelscope_model function now includes logic to check for a registered custom fetcher. If one is present, it will delegate the model download process to this custom function, ensuring extensibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@akaitsuki-ii akaitsuki-ii merged commit c058acb into main Aug 13, 2025
@akaitsuki-ii akaitsuki-ii deleted the dev/download_hook branch August 13, 2025 03:49
@gemini-code-assist
Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants